One Hour One Life Forums

a multiplayer game of parenting and civilization building

You are not logged in.

#1 2019-04-28 07:33:26

Whatever
Member
Registered: 2019-02-23
Posts: 491

Custom Pictures

EDIT: WARNING if you do this jason might ban you from the game !

The pictures you make will be send to the server.
Meaning if you use different sprites (like the fox mod) then those will be visible in the picture !

Someone pls make a funny picture with different sprites.
For example you could change the sheep sprite to an unicorn and make it look like the game has unicorns

Or take a picture while you are on shrooms

Last edited by Whatever (2019-05-01 13:36:15)

Offline

#2 2019-04-28 08:42:59

Whatever
Member
Registered: 2019-02-23
Posts: 491

Re: Custom Pictures

Tarr made a nice photo:
9d9f37c2d50962d810962081fd244c6444e731a7.jpg
looks like someone cut his head off with an axe

Offline

#3 2019-04-28 23:43:25

Mr.XIX
Member
From: The Netherlands
Registered: 2018-03-12
Posts: 175

Re: Custom Pictures

Offline

#4 2019-04-29 02:41:25

BladeWoods
Member
Registered: 2018-08-11
Posts: 476

Re: Custom Pictures

Kinda wish the photo area was a bit bigger

Offline

#5 2019-04-29 02:47:04

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

This is a bug if exploited too much. I don't see why the name of the image can't contain some sort of validation string so the it would not work from mods. That would annoy me a little as I like to zooma zooma with your AWBZ.

Or mods could require some approval to use the string...

Really though if the image has to be triggered by doing actions in-game and we don't get people clogging up the photo page with nonsense it's more amusing than something to be fixed.


---
omnem cibum costis
tantum baca, non facies opus

Offline

#6 2019-04-29 02:51:03

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

Something I've been wondering...If I use a custom server can I submit a photo?

If so those photos should be marked as not from the main server...


---
omnem cibum costis
tantum baca, non facies opus

Offline

#7 2019-04-29 02:52:47

pein
Member
Registered: 2018-03-31
Posts: 4,335

Re: Custom Pictures

had no luck of using one, i got quite a lot of sprites by default

i removed the trex but got hats floors and nudity mod, and biome textures, tiny trees


https://onehouronelife.com/forums/viewtopic.php?id=7986 livestock pens 4.0
https://onehouronelife.com/forums/viewtopic.php?id=4411 maxi guide

Playing OHOL optimally is like cosplaying a cactus: stand still and don't waste the water.

Offline

#8 2019-04-29 04:06:53

pein
Member
Registered: 2018-03-31
Posts: 4,335

Re: Custom Pictures

65fae16d2862381e5c1cc23e3ea242ffd06ad29e.jpg

so i went like crazy far for alum

made the solution
we had camera but no lack cloth so made one, half loaded loom
had to feed 4 sheep

the whole process of acids and nitrate and stuff

then made black paint cause im idiot
then painted all hats black cause why not
and a black cloth
made 4 paper in meantime messing with fires, fun fact melting knives gives you short shaft which can be cut to shavings xD

then i made the stupidest picture cause didn't understood how it works

featuring Mr XIX tiny trees and my green and yellow biome textures big_smile i dropped the wrong way around, panicked, i was already 59 until i convinced a girl to come with

i ruined it cause couldn't figure out how to use camera and i dropped reverse and died of old age xD
but if you are born as CHI then you got 3 more chances
and i brought enough stuff for one more solution for paper, including niter alum and copper foil

http://lineage.onehouronelife.com/serve … id=4278671

shows a photo near my name


https://onehouronelife.com/forums/viewtopic.php?id=7986 livestock pens 4.0
https://onehouronelife.com/forums/viewtopic.php?id=4411 maxi guide

Playing OHOL optimally is like cosplaying a cactus: stand still and don't waste the water.

Offline

#9 2019-04-29 04:12:24

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

The grass texture looks neat Pein.

Gratuitous linking of my (hopefully) helpful list of photo paper supplies:

http://onehouronelife.com/forums/viewtopic.php?id=6202

Any tips having done it? All the camps I've been in have been to young to do much so far.


---
omnem cibum costis
tantum baca, non facies opus

Offline

#10 2019-04-29 04:14:04

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

Also can someone post a screenshot of where you stand in relation to the camera?

Last edited by futurebird (2019-04-29 04:15:53)


---
omnem cibum costis
tantum baca, non facies opus

Offline

#11 2019-05-01 12:46:44

Mr.XIX
Member
From: The Netherlands
Registered: 2018-03-12
Posts: 175

Re: Custom Pictures

I saw this picture on Discord.

Can anybody verify these are Jasons words?

unknown.png

Offline

#12 2019-05-01 13:15:02

Whatever
Member
Registered: 2019-02-23
Posts: 491

Re: Custom Pictures

I think this warning needs to be in the terms of service.

This is what jason promised me when i bought the game:
- Lifetime server account
- All future updates
- Unlock on Steam
- Full source code
- Tech support included

So i dont see how he can suddenly ban people, without giving a refund, for whatever reasons that are not included in some sort of term of service that the person accepted.

Last edited by Whatever (2019-05-01 13:19:25)

Offline

#13 2019-05-01 13:38:55

Twisted
Member
Registered: 2018-10-12
Posts: 663

Re: Custom Pictures

You can see the warning right here - https://github.com/jasonrohrer/OneLife/ … e3bdf7644e

As far as I can tell this refers to people modifying the code to submit other photos from their PC instead of photos taken from the game. If you do that you get banned.

Interestingly enough the photos take a screenshot of your screen, which means that if you mod the game so everyone has dicks instead of heads the submitted photo will also have dicks instead of heads. The warning only specifies modifying the photo code, it says nothing about modifying the way your game looks.

It's an interesting problem. The ideal solution would be for the photos to display what should be seen, not what the player actually sees.

Offline

#14 2019-05-01 14:48:01

InSpace
Member
Registered: 2018-03-02
Posts: 448

Re: Custom Pictures

Oh shit, how do I take down my picture then??
q8iojuT.png

Offline

#15 2019-05-01 15:00:11

Whatever
Member
Registered: 2019-02-23
Posts: 491

Re: Custom Pictures

lol InSpace, nice one
but i know you faked it tongue

Offline

#16 2019-05-01 15:26:29

Turnipseed
Member
Registered: 2018-04-05
Posts: 680

Re: Custom Pictures

Im waiting for an all penis sprite pack to take any pictures


Be kind, generous, and work together my potatoes.

Offline

#17 2019-05-01 15:44:14

jasonrohrer
Administrator
Registered: 2017-02-13
Posts: 4,803

Re: Custom Pictures

Yes, this is a huge problem that I was aware of when designing this feature.

So here's what "security" is in place, some of it real, some of it not-so real.

1.  Each real game server has a secret key.  Before submitting a photo, you ask the photo server for a sequence number (stale sequence numbers are blocked, preventing replay attacks).  Then you ask the game server that you're connected to sign that sequence number with the secret key (generating a hash).  When you submit a photo to the photo server, it checks that it has a non-stale sequence number, and that the hash of that sequence number was really generated with a server's secret key (which you, as the player, don't even have).  So submitting while playing on unofficial servers is impossible (though it would be possible to keep two connections open, one to an unofficial, and one to an official, and use the official connection to sign sequence numbers so you can submit photos from unofficial).  Also possible to run your own unofficial photo server, by the way.   The point is that it's very hard to submit while playing on unofficial servers "by accident."  A lot of coding would be necessary.

2.  Each photo's sequence number is further signed by your own account key.  Thus, you need an account to submit photos, and it's totally blocked from general internet jack-assery, bots, etc.  To prevent simple file swapping or whatever, that same signature is embedded as a comment in the JPG file structure.  The photo server checks the sig on the request and the sig in the file before accepting.  Of course, anyone with an account could easily bypass these things with a bit of coding, and they could even make a bot to submit 100s of photos if they really wanted to (using their account).


The warning in the protocol notes was meant to dissuade people from actually hacking the game to submit truly bogus photos (porn, ads, etc).  If you do that, you will likely be looking at that protocol.txt file, and ignoring the warning, and you will be banned.

Likewise, if you explicitly hack the art of the game for this purpose (replacing characters with porn or ads or whatever).... well.... I'm not sure what I will do about that.  Hasn't happened yet.


The mods and zoom mod and such are clearly submitting modded photos by accident.  It's ugly, but not intentional.  I think the zoom mod has been somewhat fixed to "zoom in" during the moment before a photo is taken.  But regarding other mods, not sure what to do there, because I do embrace mods for the game (but the name labels are really bad, for example----cat ears less bad).

And I totally forgot about the shrooms issue.  That makes no sense, and I'll probably fix it.  You can't photograph your trip, duh!


I really don't know where to put a warning or key or whatever so that modders will need to deal with it directly before submitting photos.

I could include a key that is NOT in the source distribution..... but security by obscurity sucks, and it would be a pain in the neck for me to manage that, and that key would have to ship with the official client anyway, so it still wouldn't stop photoshop mods.  I guess I could have something in the build process that pulls the key from somewhere and embeds it in the binary code.  That would at least be a stumbling block that people would need to climb over on purpose, but again, it wouldn't stop photoshop mods.

So then we get to the idea of signing content, and checking the content sig on startup..... UGGG.

But anyway, this would also be really annoying to users, who would take a photo in a modded client and then mysteriously, it wouldn't show up in the stream.  Same for the subjects of the photo, who may not actually be using modded clients!  They wouldn't know why.  "You took my photo, and I went to look for it, and it wasn't there."  The way it's working, at least all photos that users take show up.


In general, I avoid even implementing a feature that can't be made actually secure.  But this is one rare case where the feature was really good, and the cost of implementing it securely was extremely high (graphical rendering engine server-side.... there's not even a GPU server-side, yikes).



There could be a pop-up every time you take a photo....  "Hold on there!  Only photos taken with the vanilla client and vanilla content are permitted.  Are you sure this photo is legit?  YES/NO"

But that's immersion-breaking and annoying.

Offline

#18 2019-05-01 15:48:07

jasonrohrer
Administrator
Registered: 2017-02-13
Posts: 4,803

Re: Custom Pictures

Not sure what to do about this..... you didn't even use a good font.

Offline

#19 2019-05-01 15:54:44

InSpace
Member
Registered: 2018-03-02
Posts: 448

Re: Custom Pictures

Oh snap

Offline

#20 2019-05-01 15:55:40

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

Jason you should just commit to warning and banning people who abuse the system. Your judgement call what that means. Ads and porn would likely qualify. Please don't hedge on it because then someone is going to do it just to test the boundaries. I think a lot of the nuisances we get are people just seeing what they can and can't get away with and there would be less if it were more clear.

At least this loop-hole won't allow spamming, you still have to go through the work to make a photo in the game.  (or find someone else's work as I did) so it should be manageable.

IDK. Part of my job is teaching. And one thing I've learned is to have clear boundaries because some people *need* to know where the line is and they will exhaust you testing for it if you don't just tell them. ie "if you miss a test you cannot make it up without a note from a doctor" Do I make exceptions, sometimes. But, the rules are clear. Having rules isn't bad in cases like this --it saves time and annoyance.

Just my two cents. But, maybe it will be fun to see the "all penis" sprite replacement that you *will* get if you don't say it's going to lead to a (possibly temporary) ban. Full stop.

Last edited by futurebird (2019-05-01 17:42:49)


---
omnem cibum costis
tantum baca, non facies opus

Offline

#21 2019-05-01 15:58:25

pein
Member
Registered: 2018-03-31
Posts: 4,335

Re: Custom Pictures

is my trex goose ok? big_smile

i mean you said you fine with retextures and sprite changes

i can zoom back to take a photo, i tried zoom out and actually changes the distance too, like need to be 4-5 away from the subjects so i can easily ruin it


https://onehouronelife.com/forums/viewtopic.php?id=7986 livestock pens 4.0
https://onehouronelife.com/forums/viewtopic.php?id=4411 maxi guide

Playing OHOL optimally is like cosplaying a cactus: stand still and don't waste the water.

Offline

#22 2019-05-01 16:02:49

JonySky
Member
From: Catalunya
Registered: 2018-05-13
Posts: 686
Website

Re: Custom Pictures

I love this photo!!
719ad675d93bf14c0b34d7c39907293bc5981991.jpg
I was james jewel
http://lineage.onehouronelife.com/serve … id=4303853

Last edited by JonySky (2019-05-01 16:03:43)

Offline

#23 2019-05-01 16:04:10

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

Very cute!


---
omnem cibum costis
tantum baca, non facies opus

Offline

#24 2019-05-01 17:40:02

Mr.XIX
Member
From: The Netherlands
Registered: 2018-03-12
Posts: 175

Re: Custom Pictures

jasonrohrer wrote:

Not sure what to do about this..... you didn't even use a good font.

It was more of a proof of concept, made just after release, replacing a sprite, making a joke...

Lets set a few base rules.
As far as I can see we are dealing with three groups of people here:
1. Normal users
2. Users who play with mods
3. Users that want to abuse the photo-system

From which groups do we want to see the photo's on the page?
1. Yes
2. Maybe?
3. No

Group 3 is obviously the target of the "ban-rule" but group 2 might get accidentally involved.

What if there was a "MOD" flag which can be set in settings?

That way, the front page with photo's would be all "normal photos" and you can hit the "show modded" button for pictures send by a modded client.
This would all rely on a gentleman's agreement, but wouldn't prohibit mod-users from sending photo's.

Offline

#25 2019-05-01 17:41:16

futurebird
Member
Registered: 2019-02-20
Posts: 1,553

Re: Custom Pictures

Good idea Mr. x


---
omnem cibum costis
tantum baca, non facies opus

Offline

Board footer

Powered by FluxBB